Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add shadow memory set_field operation #7846

Merged
merged 5 commits into from
Aug 22, 2023
Merged

Add shadow memory set_field operation #7846

merged 5 commits into from
Aug 22, 2023

Conversation

esteffin
Copy link
Contributor

@esteffin esteffin commented Aug 11, 2023 •
edited
Loading

PR adding supoport for shadow memory __CPROVER_set_field function.
As for the __CPROVER_get_field code is experimental and will be improved in subsequent PRs

  • Each commit message has a non-empty body, explaining why the change was made.
  • Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • White-space or formatting changes outside the feature-related changed lines are in commits of their own.

@esteffin esteffin force-pushed the esteffin/shadow-memory-set-field-op branch from 1026142 to 20329f3 Compare August 11, 2023 10:49
@NlightNFotis NlightNFotis force-pushed the esteffin/shadow-memory-set-field-op branch from 20329f3 to 63314d4 Compare August 11, 2023 11:05
NlightNFotis
NlightNFotis reviewed Aug 11, 2023
View reviewed changes
regression/cbmc-shadow-memory/no-shadow-memory-matching1/test.desc Outdated
@@ -1,4 +1,4 @@
FUTURE
CORE
main.c
--no-shadow-memory-matching '.*\.c:.*__cs_.*'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Flag doesn't exist yet, should be left FUTURE now.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed

@NlightNFotis NlightNFotis force-pushed the esteffin/shadow-memory-set-field-op branch from 63314d4 to b1dd37f Compare August 11, 2023 11:22
@NlightNFotis NlightNFotis marked this pull request as ready for review August 22, 2023 10:25
@codecov
Copy link

codecov bot commented Aug 22, 2023 •
edited
Loading

Codecov Report

Patch coverage: 77.11% and project coverage change: +0.66% 🎉

Comparison is base (74f6669) 78.19% compared to head (a3964fe) 78.85%.
Report is 27 commits behind head on develop.

Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #7846      +/-   ##
===========================================
+ Coverage    78.19%   78.85%   +0.66%     
===========================================
  Files         1698     1699       +1     
  Lines       195117   195222     +105     
===========================================
+ Hits        152566   153937    +1371     
+ Misses       42551    41285    -1266
Files Changed Coverage Δ
src/goto-symex/shadow_memory_util.cpp 81.21% <73.33%> (+19.95%) ⬆️
src/goto-symex/shadow_memory.cpp 90.41% <83.72%> (-0.50%) ⬇️

... and 86 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@NlightNFotis NlightNFotis force-pushed the esteffin/shadow-memory-set-field-op branch from 7674eae to a2f4bf4 Compare August 22, 2023 14:50
@NlightNFotis NlightNFotis force-pushed the esteffin/shadow-memory-set-field-op branch from a2f4bf4 to a3964fe Compare August 22, 2023 16:36
@NlightNFotis NlightNFotis merged commit 79186c4 into diffblue:develop Aug 22, 2023
34 of 35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NlightNFotis NlightNFotis NlightNFotis left review comments

@peterschrammel peterschrammel peterschrammel approved these changes

@kroening kroening Awaiting requested review from kroening kroening is a code owner

@tautschnig tautschnig Awaiting requested review from tautschnig tautschnig is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@esteffin @NlightNFotis @peterschrammel